Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create thumbnail button behavior #5437

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix create thumbnail button behavior #5437

merged 2 commits into from
Nov 1, 2023

Conversation

masaball
Copy link
Contributor

No description provided.

@masaball @Dananji
Fix player assignment for create thumbnail
3901cec 
Co-authored-by: Dananji Withana <dwithana@iu.edu>
cjcolvar
cjcolvar reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one suggestion to tighten things up a bit.

@masaball @cjcolvar
Limit scope of json to section ids
e2a4255 
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
Dananji
Dananji approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@masaball masaball merged commit c7dc42b into develop Nov 1, 2023
@masaball masaball deleted the fix_thumbnail_btn branch November 1, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar left review comments

@Dananji Dananji Dananji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masaball @cjcolvar @Dananji