Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to playlist #5423

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Add to playlist #5423

merged 10 commits into from
Oct 18, 2023

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Oct 12, 2023

Playlist dropdown with Add new playlist option:
image

Add to playlist with option to create playlist items for each structure item:
image

Add to playlist with option to add current track/time selection with custom title and description:
image

Display feedback from successful request:
image

Display message when the user doesn't have playlists:
image

@Dananji Dananji marked this pull request as draft October 13, 2023 14:47
…ix playlist form updating with canvas switches
@Dananji Dananji marked this pull request as ready for review October 16, 2023 13:25
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I like how you've added missing inline documentation comments for functions. I had a couple real small questions but this looks pretty much ready to go.

Dananji and others added 2 commits October 17, 2023 10:04
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@Dananji Dananji requested a review from cjcolvar October 17, 2023 17:12
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Dananji Dananji merged commit b00236e into develop Oct 18, 2023
@Dananji Dananji deleted the add-to-playlist branch October 18, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants