Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canvas reference to root range when childless divs are present #5414

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add canvas reference to root range when childless divs are present #5414

merged 2 commits into from
Oct 11, 2023

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Oct 9, 2023

No description provided.

@masaball @cjcolvar
Change XPath to check for <Span> elements
6a4c3b2 
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
cjcolvar
cjcolvar approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@masaball masaball merged commit 3215aee into develop Oct 11, 2023
@masaball masaball deleted the canvas_reference branch October 11, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @cjcolvar