Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for expanding filename and hover text #5093

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Mar 2, 2023

Fixes #5091

This PR wraps the title attribute value in quotation marks to fix hover text for titles with spaces not displaying properly. It also filters the section.label value through the truncate_center function so that all Section files truncate and expand as expected.

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cjcolvar cjcolvar merged commit 204f330 into develop Mar 7, 2023
@cjcolvar cjcolvar deleted the fix_filename_expand branch March 7, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants