Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ios fullscreen captions not displaying #4953

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Nov 10, 2022

This fix overrides the native iOS player in fullscreen mode and display a similar interface of the avalon's media player. This way the captions are accessible in a similar way to the regular player.
ios fakefullscreen

This could be a temporary fix from a UI perspective. Related ticket: #4951

@cjcolvar cjcolvar requested a review from joncameron November 11, 2022 15:32
Copy link
Contributor

@joncameron joncameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The fake fullscreen option seems to be a reasonable strategy to resolve the iOS caption issue right now and there's not much to change if there's a different strategy for handling this on mobile in the future.

@cjcolvar cjcolvar merged commit 03f4d3d into develop Nov 15, 2022
@cjcolvar cjcolvar deleted the ios-fs-captions-bugfix branch November 15, 2022 19:39
@cjcolvar cjcolvar mentioned this pull request Nov 29, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants