-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade xo
to v0.57.0
and lint sources, tests, and examples
#3305
Conversation
Disabled `unicorn/prevent-abbreviations` because it introduces too many opinionated changes.
xo
to v0.57.0
and lint sources, tests, and examples
@novemberborn Any idea why the tests are failing on Linux? |
The reporter tests are sensitive to line numbers changing, and they're now only run on Linux. See my commits here: https://github.com/avajs/ava/compare/upgrade-xo-v0.57.0-1?expand=1 (If you could let me push to your branch I can get them into this PR, or you can cherry-pick them.) |
@novemberborn Is there a safe way to do that? |
|
It does not seem to be available on this PR for some reason 🤔 |
Can you cherry-pick my commits, or merge my branch from avajs/ava into yours? |
@novemberborn Done. |
Thanks @make-github-pseudonymous-again! |
Disabled
unicorn/prevent-abbreviations
because it introduces too many opinionated changes.