Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try and let processes exit on their own instead of calling process.exit(); #241

Closed
wants to merge 2 commits into from

Conversation

jamestalmage
Copy link
Contributor

See discussion on #239

@sindresorhus
Copy link
Member

Still failing. I've had enough, let's just remove Node.js 0.10 from AppVeyor. It's already tested on Linux. ?

@jamestalmage
Copy link
Contributor Author

@jamestalmage
Copy link
Contributor Author

Here is the core issue: nodejs/node-v0.x-archive#7196

The fix needs to be back-ported to the Node 0.10 branch. A number of people have plus oned the issue, without a lot of traction.

@sindresorhus Do you know anybody working on node that could push that along? This will impact our ability to provide TAP output on Node 0.10 / Windows.

If we can't get this fixed upstream, we should at least do our users the courtesy of officially NOT supporting it, and documenting the lack of support. Something along the lines of "We support all LTS versions of Node, with the exception of 0.10 on Windows." (and a link to the relevant issue).

@sindresorhus
Copy link
Member

Do you know anybody working on node that could push that along?

@silverwind

This will impact our ability to provide TAP output on Node 0.10 / Windows.

Yeah, let's just document it. I honestly couldn't care less about an ancient Node.js version on Windows. Most people test on Travis anyways. I think we've wasted more than enough time dealing with this.

@sindresorhus
Copy link
Member

There's https://github.com/cowboy/node-exit, but process.on('exit') won't work correctly when using it.

@jamestalmage
Copy link
Contributor Author

I honestly couldn't care less about an ancient Node.js version on Windows

I am perfectly fine leaving it at that.

but process.on('exit') won't work correctly ...

I don't think process.on('exit') is being used anywhere in our code, we are using signal-exit which does things a bit different (not sure how it would be affected without testing).

@silverwind
Copy link

@jamestalmage you could just do a PR on node with that backport, targeting the v0.10 branch. Maybe it'll even make it in time for the upcoming release, see nodejs/node#2805. I don't think anyone would object merging it.

@jamestalmage jamestalmage deleted the avoid-forced-exits branch April 6, 2016 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants