Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-SDK aligning with other SDK #651

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Go-SDK aligning with other SDK #651

merged 11 commits into from
Sep 18, 2024

Conversation

kroos47
Copy link
Contributor

@kroos47 kroos47 commented Aug 29, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • [ ✔️ ] Feature
  • Bugfix
  • [ ✔️ ] Refactor
  • Format
  • Documentation
  • Testing
  • Other:

Description

Related Issues

Testing Performed

Checklist

  • I have performed a self-review of my own code.
  • The tests pass successfully with cargo test.
  • The code was formatted with cargo fmt.
  • The code compiles with no new warnings with cargo build --release and cargo build --release --features runtime-benchmarks.
  • The code has no new warnings when using cargo clippy.
  • If this change affects documented features or needs new documentation, I have created a PR with a documentation update.

@kroos47 kroos47 marked this pull request as ready for review September 2, 2024 09:04
@kroos47 kroos47 changed the title {WIP}: Go-SDK aligning with other SDK Go-SDK aligning with other SDK Sep 3, 2024
Copy link
Contributor

@Leouarz Leouarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, some small nits in comments and here :

  • There still a GO example in the old folder that needs to be deleted
  • The new folder structure is avail-go -> examples -> go-examples, the last folder can be removed
  • Is it possible to keep same naming convention for example files (all lower case with '_' as separator ?
  • Some function names start with uppercase and some with lowercase, would be great to be consistent

avail-go/examples/go-examples/DAsetApplicationKey/main.go Outdated Show resolved Hide resolved
avail-go/examples/go-examples/DAsubmitBlockLength/main.go Outdated Show resolved Hide resolved
avail-go/examples/go-examples/properties/main.go Outdated Show resolved Hide resolved
avail-go/examples/go-examples/rpc/chain_getHeader/main.go Outdated Show resolved Hide resolved
avail-go/src/header/header.go Outdated Show resolved Hide resolved
@kroos47 kroos47 merged commit ab93908 into main Sep 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants