WIP refactor of avail-core and proof generation
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelDD1
reviewed
Mar 20, 2023
Aphoh
force-pushed
the
will/grid-refactor
branch
from
8a413d8
to
b497abc
Compare
* Simplify `Debug` and `RuntimeDebug` * Clean some deps * Remove asserts from production code * CodeReview: Keep warning for future * Replace `Grid` by `NAlgebra` * Full replacement All UT pass * Fix example * Use keccak256. Signed-off-by: Sasa Prsic <sasa@ethernal.tech> * Add benchmark on reconstruction * Add benchmark * Add benchmark * Reduce memory copies * Some improvements * Refactor `avail-core` add `runtime` feature * MerkleProof under 'runtime' feature * DataLookup simplification * Add UT for `DataLookup`'s serde * Remove `AppIndex` & enforce `AppId` * Add `CompactDataLookup` * Moving `nomad` code * Improve `no-std` segragation * Dedup `Index` related stuff * Clean some deps in `nomad` * Enable CI Benchmarks * Add temporary Will's branch * Fix check fmt on CI * Fix clippy on CI * Fix check fmt on CI * Remove `Criterion` on CI * Bump up versions * Use `collect_into_vec` * Use `Dimension::weight/height()` --------- Signed-off-by: Sasa Prsic <sasa@ethernal.tech> Co-authored-by: Sasa Prsic <sasa@ethernal.tech> Co-authored-by: Saša Pršić <93726535+0xSasaPrsic@users.noreply.github.com>
Miguel/common avail core
fmiguelgarcia
approved these changes
Jul 25, 2023
fmiguelgarcia
requested review from
prabal-banerjee,
Leouarz,
ToufeeqP,
kroos47 and
markopoloparadox
markopoloparadox
approved these changes
Jul 26, 2023
Leouarz
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to completely rewrite the
kate::commodule to a cleaner API which allows a caller toCompanion PRs after this: