-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PiMo layout algorithm #227
Draft
PMunch
wants to merge
36
commits into
master
Choose a base branch
from
pimo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug requiring monitor section to be present or it would crash with a cryptic message.
Allow width/height and x/y to be set even when not in floating mode, my layout only responds to width/height at the moment, but maybe someone else will need this. Otherwise it's just moving bits and pieces around.
Also add support for gaps. Initial idea for focus changing, but currently no simple way to implement.
Note a great implementation, not a fan of how I needed to added trackedClients as an argument. I tried adding monitor instead, but that caused a lot of circular import issues that I was unable to disentangle.
I think it's missing pimo/areatools (in |
Ah crap, you do indeed. I might be able to fix it tomorrow evening |
Adds commands to grow and shrink a window in X and Y dimensions. Also added support for outerGap and resizeStep. Otherwise just some bug fixes and code cleanup.
The bug where not all actions where triggering correctly where caused by incorrectly getting the active window. This fixes that bug and cleans up the interface slightly.
New windows would incorrectly resize next to expanded windows, and windows requesting massize sizes would crash nimdow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based directly off-of the
layoutrework
branch, so you can go ahead and merge that first and this becomes four commits.Adds Nimdows first alternative layout, PiMo! PiMo is a non-overlapping window management strategy, similar to tiling window managers but respecting the size requested by the window (or controlled via app rules). Windows are laid out where there is room for them, trying to minimize how much other windows have to change their size. Moving windows around with left/right/up/down movements also tries to be as intuitive as possible. In addition to moving windows, making them float, and making them fullscreen PiMo also supports a couple more actions. Namely "expand X" and "expand Y", these basically tells the window manager that this window should attempt to be as large as possible in the X and/or Y directions. If an app rule is applied to all windows enabling both expansions the experience is similar to that of a tiling window manager, although PiMo will scale the available space based on the windows initial request. This means that if a large window like a browser is put next to a small window like a terminal then the browser will get more than 50% of the available width and the terminal will get slightly less.
Currently this should be in a useable state, however it is missing resizing options at the moment (these are very simple to implement, simply set the requested size and reshuffle the windows). I'm making this PR because I'm likely going to be away for about a week and I figured someone might want to try this out.