core/bloombits: fix deadlock when matcher session hits an error #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MatcherSession encounters an error, it attempts to close the session. Closing waits for all goroutines to finish, including the 'distributor'. However, the distributor will not exit until all requests have returned. This patch fixes the issue by delivering the (empty) result to the distributor before calling Close().
msmania
requested review from
ceyonur,
darioush and
aaronbuchwald
as code owners
darioush
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
lgtm, thanks @msmania. would you also like to make the same PR to https://github.com/ava-labs/coreth ? If not we will port the change there as well.
Thanks @darioush ! I created a PR there. |
aaronbuchwald
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
A block-pruned node encounters deadlock if a node receives
eth_getLogsfor a pruned block. The node will eventually be killed because deadlocked goroutines do not release system resources.With this patch, such
eth_getLogsimmediately returns a jsonrpc error.How this works
This patch has been merged in the upstream and will be included in the next version v1.13.2. More technical details are described in the original PR ethereum/go-ethereum#28184.
How this was tested
We had this deadlock in our DFK Chain node. This patch fixed it.
How is this documented
No change is needed.