x/warp: add predicate test for warp message from Primary Network #831

aaronbuchwald · 2023-08-31T15:20:13Z

This PR adds a unit test for verifying a warp message from the Primary Network correctly uses the validator set of the receiving subnet.

ceyonur · 2023-09-05T11:09:27Z

x/warp/predicate_test.go

+	snowCtx.SubnetID = ids.GenerateTestID()
+	snowCtx.ChainID = ids.GenerateTestID()
+	snowCtx.CChainID = cChainID
+	snowCtx.NetworkID = networkID


can we actually use constants.PrimaryNetworkID?

Updating the line below to return constants.PrimaryNetworkID instead of ids.Empty. The SubnetID declared here is meant to be a non-PrimaryNetwork SubnetID since it's receiving from the PrimaryNetwork in this test.

ceyonur · 2023-09-05T11:09:35Z

x/warp/predicate_test.go

+	snowCtx.NetworkID = networkID
+	snowCtx.ValidatorState = &validators.TestState{
+		GetSubnetIDF: func(ctx context.Context, chainID ids.ID) (ids.ID, error) {
+			if chainID != cChainID {


require.Equal?

Updating the whole test to use require.New(t)

ceyonur · 2023-09-05T11:09:57Z

x/warp/predicate_test.go

+			return ids.Empty, nil // Return Primary Network SubnetID
+		},
+		GetValidatorSetF: func(ctx context.Context, height uint64, subnetID ids.ID) (map[ids.NodeID]*validators.GetValidatorOutput, error) {
+			if subnetID != snowCtx.SubnetID {


again require.Equal could be used here instead.

ceyonur · 2023-09-05T11:12:13Z

x/warp/predicate_test.go

+	snowCtx.ChainID = ids.GenerateTestID()
+	snowCtx.CChainID = cChainID
+	snowCtx.NetworkID = networkID
+	snowCtx.ValidatorState = &validators.TestState{


can we add some comments why this is a specific behavior for primary network and what do we expect? It's a bit unclear why the test name has primary network but there is actually no primary network being used in the tests. I

This test verifies a message that is sent by the primary network, so the name is FromPrimaryNetwork. The behavior for C-Chain to Subnet message handling is documented here: https://github.com/ava-labs/subnet-evm/blob/warp-primary-network-unit-test/x/warp/README.md#performance-optimization-c-chain-to-subnet.

Is this sufficient or would you prefer a comment on the test itself?

It's sufficient, I was just expecting to see primary network ID.

…tion

* Warp stapling block context (#823) * Add GetPredicateResults to BlockContext * Serve predicate results from blockContext * Allow extra data to extend past DynamicFeeWindow post DUpgrade * Get vm warp unit tests working * Bump ANR to intermediate version to fix incompatibility with AvalancheGo * Add kc to EthKeyChain * Bump avalanchego dep in scripts for CI * Add block hash payload support * Use gomocks for precompileconfig and predicater and re-write CheckPredicates with gomocks * Use gomock for mock accessible state and block context * Fix existing warp contract tests with mock block context * Remove unused mockPredicater impl * x/warp: add contract execution unit tests * Update NewEVMBlockContext * Add AppendExtra to syncervm to fix tests * x/warp: add unit test for multiple predicate results * core: add unit test for CheckPredicates insufficient gas * Update receive warp message test to trace block and assert the expected result * Fix lint * Update warp solidity contracts * Fix block context mocks for bench * Update precompile/precompileconfig/config.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: aaronbuchwald <aaron.buchwald56@gmail.com> * Cleanup * precompile/results: Add predicate results tests + comments * nits * precompile/results: omit tx predicate results if empty * core: add invariant comment to predicate check * Address PR comments * Fix unpackWarpMessage and add unit tests * Rename OriginChainID -> SourceChainID to match ago warp message type * nits * x/warp: set public key in warp predicate unit tests * Update payload format * Clarify IWarpMessenger verified message return types * core/state: improve statedb warp specific comments * Update input param type to uint32 to avoid potential overflow on conversion * Update GetPredicateStorageSlots arg type to uint32 * warp/payload: add README for payload serialization (#835) * Fix merge * x/warp: add unit test for PrimaryNetwork to Subnet predicate verification (#831) * precompilebind: add ChainConfig with DUpgrade enabled to precompile chain config verify template

* update npm package * expand allowlist.configure * add activation func to precompile functions * move chainconfig to precompileconfig * use chainconfig in verification * trim unnecessary changes * add manager role * fix tests * add verify test * nits * add mocks * reviews * fix linter * fix benchmarks * nits * nits * fix alow list bind tests & ensure they're being tested (#841) * simplify can modify check * fix vm tests * Add manager allowlist role merge (#850) * Warp stapling block context (#823) * Add GetPredicateResults to BlockContext * Serve predicate results from blockContext * Allow extra data to extend past DynamicFeeWindow post DUpgrade * Get vm warp unit tests working * Bump ANR to intermediate version to fix incompatibility with AvalancheGo * Add kc to EthKeyChain * Bump avalanchego dep in scripts for CI * Add block hash payload support * Use gomocks for precompileconfig and predicater and re-write CheckPredicates with gomocks * Use gomock for mock accessible state and block context * Fix existing warp contract tests with mock block context * Remove unused mockPredicater impl * x/warp: add contract execution unit tests * Update NewEVMBlockContext * Add AppendExtra to syncervm to fix tests * x/warp: add unit test for multiple predicate results * core: add unit test for CheckPredicates insufficient gas * Update receive warp message test to trace block and assert the expected result * Fix lint * Update warp solidity contracts * Fix block context mocks for bench * Update precompile/precompileconfig/config.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: aaronbuchwald <aaron.buchwald56@gmail.com> * Cleanup * precompile/results: Add predicate results tests + comments * nits * precompile/results: omit tx predicate results if empty * core: add invariant comment to predicate check * Address PR comments * Fix unpackWarpMessage and add unit tests * Rename OriginChainID -> SourceChainID to match ago warp message type * nits * x/warp: set public key in warp predicate unit tests * Update payload format * Clarify IWarpMessenger verified message return types * core/state: improve statedb warp specific comments * Update input param type to uint32 to avoid potential overflow on conversion * Update GetPredicateStorageSlots arg type to uint32 * warp/payload: add README for payload serialization (#835) * Fix merge * x/warp: add unit test for PrimaryNetwork to Subnet predicate verification (#831) * precompilebind: add ChainConfig with DUpgrade enabled to precompile chain config verify template

…tion (#831)

* update npm package * expand allowlist.configure * add activation func to precompile functions * move chainconfig to precompileconfig * use chainconfig in verification * trim unnecessary changes * add manager role * fix tests * add verify test * nits * add mocks * reviews * fix linter * fix benchmarks * nits * nits * fix alow list bind tests & ensure they're being tested (#841) * simplify can modify check * fix vm tests * Add manager allowlist role merge (#850) * Warp stapling block context (#823) * Add GetPredicateResults to BlockContext * Serve predicate results from blockContext * Allow extra data to extend past DynamicFeeWindow post DUpgrade * Get vm warp unit tests working * Bump ANR to intermediate version to fix incompatibility with AvalancheGo * Add kc to EthKeyChain * Bump avalanchego dep in scripts for CI * Add block hash payload support * Use gomocks for precompileconfig and predicater and re-write CheckPredicates with gomocks * Use gomock for mock accessible state and block context * Fix existing warp contract tests with mock block context * Remove unused mockPredicater impl * x/warp: add contract execution unit tests * Update NewEVMBlockContext * Add AppendExtra to syncervm to fix tests * x/warp: add unit test for multiple predicate results * core: add unit test for CheckPredicates insufficient gas * Update receive warp message test to trace block and assert the expected result * Fix lint * Update warp solidity contracts * Fix block context mocks for bench * Update precompile/precompileconfig/config.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: aaronbuchwald <aaron.buchwald56@gmail.com> * Cleanup * precompile/results: Add predicate results tests + comments * nits * precompile/results: omit tx predicate results if empty * core: add invariant comment to predicate check * Address PR comments * Fix unpackWarpMessage and add unit tests * Rename OriginChainID -> SourceChainID to match ago warp message type * nits * x/warp: set public key in warp predicate unit tests * Update payload format * Clarify IWarpMessenger verified message return types * core/state: improve statedb warp specific comments * Update input param type to uint32 to avoid potential overflow on conversion * Update GetPredicateStorageSlots arg type to uint32 * warp/payload: add README for payload serialization (#835) * Fix merge * x/warp: add unit test for PrimaryNetwork to Subnet predicate verification (#831) * precompilebind: add ChainConfig with DUpgrade enabled to precompile chain config verify template

aaronbuchwald added the warp label Aug 31, 2023

aaronbuchwald self-assigned this Aug 31, 2023

aaronbuchwald requested review from ceyonur and darioush as code owners August 31, 2023 15:20

darioush approved these changes Aug 31, 2023

View reviewed changes

ceyonur reviewed Sep 6, 2023

View reviewed changes

ceyonur approved these changes Sep 12, 2023

View reviewed changes

Base automatically changed from warp-stapling-block-context to master September 12, 2023 17:10

aaronbuchwald requested a review from anusha-ctrl as a code owner September 12, 2023 17:10

x/warp: add unit test for PrimaryNetwork to Subnet predicate verifica…

f2da93a

…tion

aaronbuchwald force-pushed the warp-primary-network-unit-test branch from 979bc87 to f2da93a Compare September 12, 2023 17:26

aaronbuchwald merged commit cf95fc5 into master Sep 12, 2023
8 checks passed

aaronbuchwald deleted the warp-primary-network-unit-test branch September 12, 2023 17:47

ceyonur pushed a commit that referenced this pull request Sep 14, 2023

x/warp: add unit test for PrimaryNetwork to Subnet predicate verifica…

232d8ed

…tion (#831)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/warp: add predicate test for warp message from Primary Network #831

x/warp: add predicate test for warp message from Primary Network #831

aaronbuchwald commented Aug 31, 2023

ceyonur Sep 5, 2023

aaronbuchwald Sep 12, 2023

ceyonur Sep 5, 2023

aaronbuchwald Sep 12, 2023

ceyonur Sep 5, 2023

aaronbuchwald Sep 12, 2023

ceyonur Sep 5, 2023

aaronbuchwald Sep 12, 2023

ceyonur Sep 12, 2023

x/warp: add predicate test for warp message from Primary Network #831

x/warp: add predicate test for warp message from Primary Network #831

Conversation

aaronbuchwald commented Aug 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment