core/txpool/legacypool: respect nolocals-setting #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening the PR! Changes LGTM but there was an issue with load testing which was fixed with #1157. Seems that golangci has an issue as well. Will fix it and unblock this PR. |
|
Could you fix linter errors (they're real errors this time) @PutraLaksmana? |
|
No problem |
|
Sorry, I pushed it by mistake. |
ceyonur
previously approved these changes
Apr 21, 2024
darioush
previously approved these changes
Apr 21, 2024
auto-merge was automatically disabled
April 22, 2024 05:48
Head branch was pushed to by a user without write access
Signed-off-by: Putra Laksmana <92698143+PutraLaksmana@users.noreply.github.com>
Signed-off-by: Putra Laksmana <92698143+PutraLaksmana@users.noreply.github.com>
Signed-off-by: Putra Laksmana <92698143+PutraLaksmana@users.noreply.github.com>
Signed-off-by: Putra Laksmana <92698143+PutraLaksmana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Ensure that transactions added to the legacy pool are not treated as 'locals' if the global locals-management has been disabled.
Actually This PR from go-ethereum.
ethereum/go-ethereum#28435
How this works
This change makes the pool enforce the --txpool.pricelimit setting.
How this was tested
Good
How is this documented
.