Skip to content

chore(ci): linting job changes regarding goheader #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore(ci): linting job changes regarding goheader #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,17 @@ jobs:
- uses: actions/setup-go@v5
with:
go-version: stable
- name: golangci-lint
- name: goheader
# The goheader linter is only enabled in the CI so that it runs only on modified or new files
# (see only-new-issues: true). It is disabled in .golangci.yml because
# golangci-lint running locally is not aware of new/modified files compared to the base
# commit of a pull request, and we want to avoid reporting invalid goheader errors.
uses: golangci/golangci-lint-action@v6
with:
version: v1.60
only-new-issues: true
# The goheader linter is enabled so that it runs only on modified or new files
# (see only-new-issues: true). Note it is disabled in .golangci.yml because
# golangci-lint is not aware of new/modified files compared to the last git commit,
# and we want to avoid reporting invalid goheader errors when running the linter locally.
args: --enable goheader
args: --enable-only goheader
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.60