check against eth hash #808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuris
reviewed
Feb 27, 2025
| @@ -1752,6 +1750,50 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "ethhash")] | |||
There was a problem hiding this comment.
If you move this test over to ethhash.rs you can avoid adding this directive
| @@ -48,6 +48,11 @@ clap = { version = "4.5.0", features = ['derive'] } | |||
| pprof = { version = "0.14.0", features = ["flamegraph"] } | |||
| tempfile = "3.12.0" | |||
| tokio = { version = "1.36.0", features = ["rt", "sync", "macros", "rt-multi-thread"] } | |||
| ethereum-types = "0.15.1" | |||
There was a problem hiding this comment.
These should all contain features flags to make the build faster without the feature flag enabled
Suggested change
| ethereum-types = "0.15.1" | |
| ethereum-types = { version = "0.15.1", features = [ "ethhash" ] } |
|
closing, the relevant commits was already added to 807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.