ethhash WIP #807
Draft
ethhash WIP #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a hashers module so that we can split out the code needed by merkledb from the new ethhash option.
Don't recreate the iterator each time, instead consume it using a for loop.
Added new HashType type alias to decide which compatibilty we need Tests pass, needs cleanup. Lots of print lines to remove. Doesn't compile without ethhash. Co-authored-by: Darioush Jalali <darioush@users.noreply.github.com>
The problem here is still some grey areas around when TrieHash is really required and when HashType is supposed to be used. Added some clippy allows for useless_conversions which the compiler should optimize away anyway to work around this, but a better approach might be to use another method on TrieHash to create a HashType from it rather than just calling into which can give the clippy warning.
- Removed some stray comments, added some, and fixed a few others - Allowed for compiling successfully regardless of feature flags - Left in some trace! calls but gated them with a new logger method to check if the log message for trace would be generated to prevent calling hex::encode on debug strings (perf) - Implemented serde serializer on ethhash for debugging
We now have this transformation down to the two cases we care about and compute everything in one fell swoop, with no mutable variables. See the inline comments for exactly how this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashednode should really be split into two files so that we aren't doing so many #[cfg(...)] checks inline, but this is a good starting point for adding some tests.