Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the following metrics: #800

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Adds the following metrics: #800

merged 1 commit into from
Feb 23, 2025

Conversation

rkuris
Copy link
Collaborator

@rkuris rkuris commented Feb 23, 2025

  • each ffi batch reports "firewood.ffi.batch_ms" for elapsed millis
  • each ffi batch reports "firewood.ffi.batch" for each run (allows the mean time per call to be batch_ms/batch)
  • each predictive_reader reports "firewood.io.read_ms" for elapsed millis
  • each predictive_reader reports "firewood.io.read" for each run

These should complete the following requested statistics:

  • What percentage of time is spent performing blocking DB reads during EVM execution (now in firewood.io.read*)
  • What percentage of time is spent during merkalization after EVM execution -> (now in firewood.ffi.batch*)

These other statistics were already available:

  • What percentage of time is spent during EVM execution (the EVM records these)
  • What is our CPU utilization during the benchmark (Are we CPU bound?) (the system level node recorder records these)
  • What is our RAM utilization during the benchmark (Are we using memory more efficiently?) (the system level node recorder records these)
  • What is our disk utilization during the benchmark (Are we fully utilizing our available IOPS) (the node recorder records these too)

 - each ffi batch reports "firewood.ffi.batch_ms" for elapsed millis
 - each ffi batch reports "firewood.ffi.batch" for each run
   (allows the mean time per call to be batch_ms/batch)
 - each predictive_reader reports "firewood.io.read_ms" for elapsed
   millis
 - each predictive_reader reports "firewood.io.read" for each run

These should complete the following requested statistics:

 - What percentage of time is spent performing blocking DB reads
   during EVM execution (now in firewood.io.read*)
 - What percentage of time is spent during merkalization after
   EVM execution -> (now in firewood.ffi.batch*)

These other statistics were already available:

 - What percentage of time is spent during EVM execution
   (the EVM records these)
 - What is our CPU utilization during the benchmark (Are we CPU bound?)
   (the system level node recorder records these)
 - What is our RAM utilization during the benchmark (Are we using memory
   more efficiently?) (the system level node recorder records these)
 - What is our disk utilization during the benchmark (Are we fully
   utilizing our available IOPS) (the node recorder records these too)
@rkuris rkuris self-assigned this Feb 23, 2025
@rkuris rkuris merged commit 2b50c16 into main Feb 23, 2025
5 checks passed
@rkuris rkuris deleted the rkuris/new-metrics branch February 23, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant