Implement iterator over nodes; refactor key-value iterator #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
February 5, 2024 09:44
danlaine
requested review from
xinifinity,
rkuris and
richardpringle
as code owners
richardpringle
approved these changes
Feb 8, 2024
rkuris
approved these changes
Feb 8, 2024
| == Ordering::Greater | ||
| { | ||
| // `child` is after `key`. | ||
| let key = matched_key_nibbles |
There was a problem hiding this comment.
nit: since we're doing exactly the same thing earlier, perhaps a helper function would be useful here
| } | ||
| check_stream_is_done(stream).await; | ||
|
|
||
| // Test with start key |
richardpringle
approved these changes
Feb 8, 2024
richardpringle
approved these changes
Feb 12, 2024
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternate implementation to #499.
This PR implements an iterator over nodes. The iterator can be configured to start at a given key. Uses this node iterator to refactor the key-value iterator implementation.