fix: correct ledger buffer size calculation for Sign function #4376
+21
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous buffer size calculation incorrectly assumed signing and change paths were stored separately in the ledger buffer. However, the ledger library deduplicates these paths, and the buffer format includes a 1-byte path count prefix. This fixes the calculation to accurately reflect the actual buffer usage.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ledger buffer size calculation for the Sign function. The previous implementation incorrectly calculated buffer usage by assuming signing and change paths were stored separately, when in fact the ledger library deduplicates these paths.
- Fixed buffer size calculation to account for path deduplication and proper buffer format
- Added comprehensive documentation explaining ledger buffer limits and device compatibility
- Updated comments to reference the correct ledger library implementation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds documentation explaining that ledgerPathSize (9 bytes) matches the serialized format produced by SerializePathSuffix in the ledger library: 1 byte for component count + 4 bytes per component for a 2-component path suffix like "0/123".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The previous buffer size calculation incorrectly assumed signing and change paths were stored separately in the ledger buffer. However, the ledger library deduplicates these paths, and the buffer format includes a 1-byte path count prefix. This fixes the calculation to accurately reflect the actual buffer usage.
How this works
How this was tested
Need to be documented in RELEASES.md?