feat: Use the new ETA tracker for re-execution tests #4352
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the deprecated EstimateETA function with EtaTracker.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated EstimateETA function with the new EtaTracker for better ETA estimation during VM re-execution load tests.
- Replaces deprecated
timer.EstimateETAfunction withtimer.EtaTracker - Adds proper initialization of ETA tracking with baseline samples
- Improves ETA calculation accuracy during block execution sequences
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment was marked as resolved.
This comment was marked as resolved.
rkuris
changed the title
aaronbuchwald
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Code change LGTM
Would you mind attaching logs from the two comparison runs before/after this PR to show that the ETA is more accurate with this change, so that there's at least one clear data point?
Approving regardless since either way this is replacing deprecated code.
RodrigoVillar
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the deprecated EstimateETA function with EtaTracker.
Why this should be merged
Because the new EtaTracker is much better
How this works
Removed the deprecated call and replaced it with the new one
How this was tested
Reran the test and see that it now has better estimates
Need to be documented in RELEASES.md?
No