[ci] Remove run_env from run-monitored-tmpnet-cmd #4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the transition to using go-task, all CI jobs are responsible for internalizing env vars and arguments to simplify local reproduction of CI failures. This removes the need for the run-monitored-tmpnet-cmd to support providing env vars via run_env.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the run_env parameter from the run-monitored-tmpnet-cmd GitHub Action as part of transitioning to go-task for CI job management. The change simplifies the action by requiring tasks to internalize their environment variables and arguments, making CI failures easier to reproduce locally.
- Removes
run_envinput parameter from the GitHub Action definition - Updates documentation to reflect the new task-based approach instead of script-based execution
- Modifies the command execution to no longer prepend environment variables
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/actions/run-monitored-tmpnet-cmd/action.yml | Removes run_env input parameter and updates command execution |
| tests/fixture/tmpnet/README.md | Updates documentation with new task-based usage pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
With the transition to using go-task, all CI jobs are responsible for internalizing env vars and arguments to simplify local reproduction of CI failures. This removes the need for the run-monitored-tmpnet-cmd custom action to support providing env vars via run_env.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A