sync -- nits and cleanup
#1674
Merged
sync -- nits and cleanup
#1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Jun 30, 2023
| @@ -133,19 +132,6 @@ func (s *NetworkServer) AppRequest( | |||
| return nil | |||
| } | |||
|
|
|||
| // isTimeout returns true if err is a timeout from a context cancellation | |||
| // or a context cancellation over grpc. | |||
| func isTimeout(err error) bool { | |||
danlaine
commented
Jun 30, 2023
| @@ -494,30 +493,6 @@ func (m *Manager) findNextKey( | |||
| return nextKey, nil | |||
| } | |||
|
|
|||
| // findChildDifference returns the first child index that is different between node 1 and node 2 if one exists and | |||
| // a bool indicating if any difference was found | |||
| func findChildDifference(node1, node2 *merkledb.ProofNode, startIndex byte) (byte, bool) { | |||
darioush
approved these changes
Jun 30, 2023
anusha-ctrl
approved these changes
Jun 30, 2023
ramilexe
pushed a commit
to ConsiderItDone/avalanchego
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
A little cleanup.
How this works
Move a few functions, rename a few things, convert a bunch of
ifs into aswitchHow this was tested
Existing UT