-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contribution file #1373
add contribution file #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some general feedback. I have written several of these contributing guides at my last job so I have some experience.
|
||
### Did you fix whitespace, format code, or make a purely cosmetic patch? | ||
|
||
- Changes from the community that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of `avalanchego` will generally not be accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come this is the case? I think small formatting commits could be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to avoid unnecessary noise prs (rearranging the readme, reformatting whitespace, etc). I'm down to not include this on the first pass of this if people dont like this
|
||
### Do you want to contribute to the Avalanche documentation? | ||
|
||
- Please check out the `avalanche-docs` repository [here](https://github.com/ava-labs/avalanche-docs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could mention the Avalanche dev call as an additional resource for those interested in contributing? Date/time/etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting to hear back from gabriel on what the link to the call is since it's not on my calendar but we can prob merge this in as-is and add this later whenever i hear back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small formatting nits
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Why this should be merged
Adds a contribution guideline file
How this works
Adds some guidelines for community contributions
How this was tested
N/A