Remove DAG based consensus #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into linearize-on-start
StephenButtolph
added
consensus
StephenButtolph
commented
Apr 15, 2023
Comment on lines
-341
to
-343
| if err := stopVertex.Verify(ctx); err != nil { | ||
| return fmt.Errorf("failed to verify stop vertex: %w", err) | ||
| } |
There was a problem hiding this comment.
Unlike block or tx verify, vertex verification was stateless, so this doesn't need to exist anymore
StephenButtolph
commented
Apr 15, 2023
| @@ -433,16 +247,6 @@ func (vtx *uniqueVertex) Height() (uint64, error) { | |||
| return vtx.v.vtx.Height(), nil | |||
| } | |||
|
|
|||
| func (vtx *uniqueVertex) Epoch() (uint32, error) { | |||
There was a problem hiding this comment.
This was already dead code... apparently
StephenButtolph
commented
Apr 15, 2023
| "github.com/ava-labs/avalanchego/utils" | ||
| "github.com/ava-labs/avalanchego/utils/hashing" | ||
| ) | ||
|
|
||
| // Builder builds a vertex given a set of parentIDs and transactions. | ||
| type Builder interface { | ||
| // Build a new vertex from the contents of a vertex | ||
| BuildVtx(ctx context.Context, parentIDs []ids.ID, txs []snowstorm.Tx) (avalanche.Vertex, error) | ||
| // Build a new stop vertex from the parents | ||
| BuildStopVtx(ctx context.Context, parentIDs []ids.ID) (avalanche.Vertex, error) | ||
| } |
There was a problem hiding this comment.
Technically we should be able to remove the below Build function, but it's used for testing.
gyuho
reviewed
Apr 15, 2023
joshua-kim
approved these changes
Apr 26, 2023
abi87
reviewed
Apr 26, 2023
abi87
approved these changes
Apr 26, 2023
coffeeavax
approved these changes
Apr 26, 2023
gyuho
reviewed
Apr 26, 2023
| // BetaRogue to be equal. Therefore we use the more conservative | ||
| // BetaRogue value for both BetaVirtuous and BetaRogue. | ||
| // | ||
| // TODO: After the X-chain linearization use the |
gyuho
approved these changes
Apr 26, 2023
joshua-kim
pushed a commit
to joshua-kim/avalanchego
that referenced
this pull request
Apr 28, 2023
Co-authored-by: Stephen <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
All consensus instances are now chain based.
How this works
Removes the Avalanche consensus engine and avalanche consensus instance.
How this was tested
CI + TODO: local testing