Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor concurrent work limiting in sync in x/sync #1347

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

danlaine
Copy link

Why this should be merged

It's better to wait and then start a goroutine than to create a goroutine and then wait.

How this works

Instead of making a goroutine to handle the work item, then have the goroutine wait until we're under the concurrent work limit, don't create the goroutine until we're under the concurrent work limit.

How this was tested

Existing UT

@danlaine danlaine merged commit ced2874 into dev Apr 21, 2023
@danlaine danlaine deleted the sync-refactor-wait branch April 21, 2023 19:38
@patrick-ogrady patrick-ogrady added this to the v1.10.1 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants