Ban usage of require.Error #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
testing
StephenButtolph
commented
Apr 14, 2023
x/merkledb/history_test.go
Outdated
| _, err = db.history.getValueChanges(toBeDeletedRoot, endRoot, nil, nil, 1) | ||
| require.Error(err, ErrRootIDNotPresent) | ||
| require.ErrorIs(err, ErrStartRootNotFound) |
There was a problem hiding this comment.
@dboehm-avalabs this error wasn't correct - lmk if this error is unexpected.
StephenButtolph
changed the base branch from
utils-error-handling
to
consensus-error-handling
StephenButtolph
changed the base branch from
consensus-error-handling
to
not-platformvm-error-handling
StephenButtolph
requested review from
abi87,
danlaine and
joshua-kim
as code owners
exdx
approved these changes
Apr 21, 2023
dhrubabasu
reviewed
Apr 22, 2023
| sharedMemory atomic.SharedMemory | ||
| sourceKeys []*secp256k1.PrivateKey | ||
| timestamp time.Time | ||
| expectedBuildError error |
There was a problem hiding this comment.
nit: can we do expectedErr since we're only testing build?
StephenButtolph
requested review from
darioush and
dboehm-avalabs
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Tests using
require.Errorcan be subtly incorrect because an unexpected error may be returned.How this works
Bans the usage of
require.Errorand removes all usage ofrequire.ErrorHow this was tested
CI