Use require in Avalanche bootstrapping tests #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Apr 13, 2023
| @@ -10,7 +10,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| Initializing = iota | |||
| Initializing State = iota | |||
There was a problem hiding this comment.
This is needed to enable using require.Equal rather than require.EqualValues (or explicitly casting)
darioush
approved these changes
Apr 13, 2023
danlaine
reviewed
Apr 14, 2023
danlaine
reviewed
Apr 14, 2023
danlaine
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We are changing core behavior of the avalanche bootstrapper in a future release. This means we need to update the tests.... but the tests are currently pretty gross to look at... So trying to make me hate the refactor a little less.
How this works
if ... { t.Fatal(...) }is outrequire...(...)is in.How this was tested
CI