Remove bitmask from writeMsgLen #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
the
DO NOT MERGE
|
This must not be merged until after Cortina activates. |
StephenButtolph
added
cleanup
joshua-kim
approved these changes
Apr 13, 2023
StephenButtolph
removed
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is a continuation of our switch to
proto. All nodes in the network (after v1.10 activates) will ignore the most significant bit in the message length, so we can remove the explicit setting of it. We still need to ignore the most significant bit until everyone in the network no longer sets it (adopts this update) which will only be guaranteed after the following network upgrade (v1.11).How this works
Stops setting the MSB in the message length.
How this was tested
CI