Use proto in x/sync
#1336
Merged
Use proto in x/sync
#1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 12, 2023 17:50
danlaine
requested review from
darioush,
dboehm-avalabs,
gyuho and
hexfusion
as code owners
darioush
approved these changes
Apr 13, 2023
hexfusion
reviewed
Apr 13, 2023
hexfusion
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We want to use proto for encoding whenever a canonical byte representation isn't required.
How this works
Remove
ChangeProofRequestandRangeProofRequestand replace them with proto typesHow this was tested
Existing UT