Remove no-op changes from history results #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dboehm-avalabs
commented
Apr 12, 2023
| } | ||
| } | ||
|
|
||
| return true | ||
| }, | ||
| ) | ||
|
|
||
| // Keep only the smallest [maxLength] items in [combinedChanges.values]. | ||
| for sortedKeys.Len() > maxLength { |
There was a problem hiding this comment.
move this outside of the loop since a no-op key/value could cause a value that was preiously excluded to be included again.
darioush
approved these changes
Apr 12, 2023
danlaine
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getValueChanges can end up including no-op key/value changes. Add a check to remove them from the results.