-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fine grained metrics+logging for handling, processing, and grab l… #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock times in snow handler
aaronbuchwald
commented
Apr 6, 2023
aaronbuchwald
commented
Apr 6, 2023
aaronbuchwald
commented
Apr 6, 2023
aaronbuchwald
commented
Apr 6, 2023
aaronbuchwald
commented
Apr 6, 2023
darioush
approved these changes
Apr 6, 2023
darioush
approved these changes
Apr 6, 2023
joshua-kim
reviewed
Apr 6, 2023
super minor nits, one question on if we should add a metric on acquire time in addition to the held time we're adding |
Good call @joshua-kim |
StephenButtolph
approved these changes
Apr 6, 2023
joshua-kim
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds more fine grained tracking for the amount of time spent in message processing. Currently, message processing tracks the amount of time spent handling a message including the time spent grabbing the engine lock. This PR breaks down the handling time into:
Note: these metrics are observed both before and after bootstrapping, so new nodes that spend a long time bootstrapping may have very skewed metrics at the start.
How this works
This PR tracks the new finer grained metrics and updates the warn log reported in #1286 to include all three, so that we have more information when this warn occurs.
How this was tested
This PR is tested in CI and by running locally with the ANR to observe that the metrics show up as expected:
Note: I kept the name of the original metric for the total time spent handling the message the same, so that existing metrics are unchanged. This has the unfortunate side effect that the output now shows the count at the beginning and the sum at the end, with the other metrics in between, but this is only a problem when viewing the raw metrics with grep.