-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sample_sensor_kit_launch): concatenate node load from parameter file #108
base: main
Are you sure you want to change the base?
feat(sample_sensor_kit_launch): concatenate node load from parameter file #108
Conversation
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
I'm not sure about duplicating parameter files. If there is an update to the concat node in the future, this duplicated config needs to be updated in a PR to sample_sensor_kit_launch as well. |
@mojomex I agree that loading additional parameter files from sensor_kit makes the procedure more complicated but for the aip_launcher this is needed since each project has its own parameters 😿 If aip_launcher needs to be implemented in this way, sample_sensor_kit should follow the same approach to maintain consistency. |
67046ee
to
db5489e
Compare
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Description
This PR remove the default parameter from the node.
Thus, the launcher also needs to load from the parameter file.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.