Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner::blind_spot): consider adjacent lane #267

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 27, 2023

Description

feature PR: autowarefoundation/autoware.universe#3175

Related links

https://tier4.atlassian.net/browse/T4PB-24187

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin marked this pull request as ready for review March 27, 2023 05:50
@soblin soblin requested a review from tkimura4 March 27, 2023 06:06
tkimura4 referenced this pull request in tier4/autoware_launch Mar 29, 2023
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
@@ -3,7 +3,8 @@
blind_spot:
use_pass_judge_line: true
stop_line_margin: 1.0 # [m]
backward_length: 15.0 # [m]
backward_length: 50.0 # [m]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soblin
Could you tell me the reason of this chage?

Copy link
Contributor Author

@soblin soblin Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this value is 15m, ego vehicle will detect collision with a bike only when (1) ego is within 15m from the stop line and (2) the bike is within 15m from the stop line and behind ego.
So ego vehicle need to completely stop while travelling less than 15m, at least 0.24G deceleration is required if its speed was 30kmph.
Maybe I should decide this value using pass judge length.

@soblin soblin merged commit e836c1d into autowarefoundation:main Apr 5, 2023
@soblin soblin deleted the feat/blind-spot-neighboring-lane branch April 5, 2023 10:19
maxime-clem added a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
…le (autowarefoundation#267)

feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module (autowarefoundation#730)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants