Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): fix detection area being ignored when the ego vehicle stops over the stop line #260

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Mar 17, 2023

Description

Related PR: autowarefoundation/autoware.universe#3114

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

mkuri added 2 commits March 17, 2023 20:59
(hold_stop_margin_distance)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
… stop line

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri merged commit bb54fcf into autowarefoundation:main Mar 24, 2023
LeoDriveProject pushed a commit to leo-drive/autoware_launch.golf that referenced this pull request Apr 12, 2023
… the ego vehicle stops over the stop line (autowarefoundation#260)

* chore(behavior_velocity_planner): follow the latest implementation
(hold_stop_margin_distance)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* feat(behavior_velocity_planner): add a parameter for judging over the stop line

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jan 11, 2024
…in-sync

chore: sync beta branch beta/v0.18.0 with tier4/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants