fix: changed loc_config_path declaration from let to arg

[SakodaShintaro]

Description

Context

Currently, Autoware cannot accept the argument ndt_scan_matcher/ndt_scan_matcher_param_path.

NG)

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$MAP \
    ndt_scan_matcher/ndt_scan_matcher_param_path:=/your/path

This is because the argument is overwritten in tier4_localization_component.launch.xml.

autoware_launch/autoware_launch/launch/components/tier4_localization_component.launch.xml

Line 27 in 642eb3e

<arg name="ndt_scan_matcher/ndt_scan_matcher_param_path" value="$(var loc_config_path)/ndt_scan_matcher/ndt_scan_matcher.param.yaml"/>

The loc_config_path is not an argument, as it is declared using let.

autoware_launch/autoware_launch/launch/components/tier4_localization_component.launch.xml

Line 3 in 642eb3e

<let name="loc_config_path" value="$(find-pkg-share autoware_launch)/config/localization"/>

Also NG)

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$MAP \
    loc_config_path:=/your/path

Changes

In this pull request, I have changed the loc_config_path declaration from let to arg.

OK!)

ros2 launch autoware_launch logging_simulator.launch.xml \
    map_path:=$MAP \
    loc_config_path:=/your/path

Tests performed

• planning_simulator with sample_map
• logging_simulator with sample_rosbag
• logging_simulator with awsim_gt_data(TIER IV INTERNAL)
• e2e_simulator with AWSIM v1.3.0

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.