Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename use_external_emergency_stop to check_external_emergency_heartbeat #120

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Dec 6, 2022

Description

See autowarefoundation/autoware.universe#2455

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@h-ohta h-ohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmpwk shmpwk merged commit ba52539 into autowarefoundation:main Dec 7, 2022
@shmpwk shmpwk deleted the fix/rename_use_external_emergency_stop branch December 7, 2022 10:27
shmpwk added a commit to shmpwk/autoware_launch that referenced this pull request Dec 12, 2022
shmpwk added a commit that referenced this pull request Dec 19, 2022
* fix: rename use_external_emergency_stop to check_external_emergency_heartbeat (#120)

* fix: change check_external_emergency_heartbeat false (#119)

* fix: use_external_emergenc_stop false

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

* Update autoware.launch.xml

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>

Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants