Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove web controller #117

Merged

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Nov 30, 2022

Description

Currently, Autoware has a web controller. In the early days, Autoware was controlled via web controller.
https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/launch/autoware.launch.xml#L145

However, Now that the autoware state rviz plugin has been introduced, the need for web controller seems to have disappeared.
https://github.com/orgs/autowarefoundation/discussions/3082

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@yukkysaito yukkysaito force-pushed the feature/remove-web-controller branch from ec77b46 to fb5458d Compare November 30, 2022 09:16
@yukkysaito yukkysaito changed the title Feature/remove web controller feat: remove web controller Nov 30, 2022
@yukkysaito yukkysaito marked this pull request as ready for review December 7, 2022 07:27
@yukkysaito yukkysaito merged commit 1f96883 into autowarefoundation:main Dec 7, 2022
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 26, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants