Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

feat(map_loader): show intersection areas #211

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 25, 2023

Description

Add util function to show intersection area.

Screenshot from 2023-10-25 09-07-16

Tests performed

Psim.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c3a1a19) 11.34% compared to head (edc57ab) 11.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   11.34%   11.31%   -0.04%     
==========================================
  Files          36       36              
  Lines        2652     2660       +8     
  Branches     1357     1363       +6     
==========================================
  Hits          301      301              
- Misses       1931     1939       +8     
  Partials      420      420              
Flag Coverage Δ *Carryforward flag
differential 9.64% <0.00%> (?)
total 11.34% <ø> (ø) Carriedforward from c3a1a19

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
tmp/lanelet2_extension/lib/visualization.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit 6054e6b into autowarefoundation:main Oct 25, 2023
17 of 19 checks passed
@satoshi-ota satoshi-ota deleted the feat/show-intersection-area branch October 25, 2023 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants