Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add planning/control launch files to autoware:universe-planning-control images #5587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 19, 2024

Description

This PR makes it possible to run the autoware:universe-planning-control containers using the launch files designed for the components.

Ref. #5394

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Dec 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Dec 19, 2024
@youtalk youtalk requested review from xmfcx and mitsudome-r December 19, 2024 13:25
Comment on lines +68 to +69
COPY src/universe/autoware.universe/launch/tier4_control_launch /autoware/src/universe/autoware.universe/launch/tier4_control_launch
COPY src/universe/autoware.universe/launch/tier4_planning_launch /autoware/src/universe/autoware.universe/launch/tier4_planning_launch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tier4_control_launch depends on the following packages from other folders:

  • autoware.universe/vehicle/autoware_external_cmd_converter
  • autoware.universe/vehicle/autoware_raw_vehicle_cmd_converter

tier4_planning_launch depends on the following packages from other folders:

  • autoware.universe/evaluator/autoware_planning_evaluator

Should we copy them as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/autowarefoundation/autoware/actions/runs/12413592198/job/34655831530?pr=5587#step:5:1722

#55 3.305 ERROR: no rosdep rule for 'autoware_external_cmd_converter'
#55 3.305 ERROR: no rosdep rule for 'autoware_control_evaluator'
#55 3.305 ERROR: no rosdep rule for 'autoware_planning_evaluator'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants