feat: add autoware_auto_msgs_adapter #4802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have made this PR a draft so that this won't be merged before autowarefoundation/autoware.universe#7220, but this is ready for review. |
mitsudome-r
force-pushed
the
port-autoware-auto-msgs-adapter
branch
from
c5766fd to
cdd9a33
Compare
6 tasks
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
mitsudome-r
force-pushed
the
port-autoware-auto-msgs-adapter
branch
from
cdd9a33 to
f52ea95
Compare
|
xmfcx
approved these changes
Jun 19, 2024
xmfcx
reviewed
Jun 19, 2024
| @@ -73,6 +73,10 @@ repositories: | |||
| type: git | |||
| url: https://github.com/tier4/glog.git | |||
| version: v0.6.0_t4-ros | |||
| universe/external/autoware_auto_msgs_adapter: # TODO(mitsudome-r): Remove when transition period to autoware_msgs is over | |||
There was a problem hiding this comment.
Suggested change
| universe/external/autoware_auto_msgs_adapter: # TODO(mitsudome-r): Remove when transition period to autoware_msgs is over | |
| universe/autoware_auto_msgs_adapter: # TODO(mitsudome-r): Remove when transition period to autoware_msgs is over |
External folders were for repositories outside of the https://github.com/autowarefoundation organization.
xmfcx
requested changes
Jun 19, 2024
|
Since all messages have been converted to autoware_msgs, we don't need it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of autowarefoundation/autoware.universe#7219
This must be merged after autowarefoundation/autoware.universe#7220 to avoid duplicate package within the same colcon workspace.
Tests performed
Build test done on local machine.
Effects on system behavior
None
Interface changes
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.