Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs that the latest tag is not parsed #330

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Dec 19, 2024

Description

Fix a bug that the newest tag is not applied for the created PRs.

Tests performed

The tests are performed by using this repository. The used workflow is provided here. Also you can see the result of the workflow from here.

We verified the following test is passed:

Condition:

  • Fix the current version to be 0.0.1
  • On the target repository, there are tags like:
    • 7.3.3, 7.3.2, ... , 0.9.0, 0.8.0, ... 0.1.1, 0.1.0, and 0.0.1

What is tested?:

Notes for reviewers

Any proposal and comments are highly appreciated! For example, please let us know missing / effective test strategies for this PR. I'm happy for performing the proposed tests and applying code change proposals, ... etc 👍

Interface changes

No change

ROS Topic Changes

No change

ROS Parameter Changes

No change

Effects on system behavior

Due to the bug fix, some possible version update PRs will be created on the autowarefoundation/autoware

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
@sasakisasaki sasakisasaki self-assigned this Dec 19, 2024
@sasakisasaki sasakisasaki added the bug Something isn't working label Dec 19, 2024
@xmfcx xmfcx changed the title bug: fix bugs that the latest tag is not parsed fix: bugs that the latest tag is not parsed Dec 19, 2024
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sasakisasaki sasakisasaki merged commit f33a673 into autowarefoundation:main Dec 20, 2024
12 of 18 checks passed
@sasakisasaki sasakisasaki deleted the fix-bugs-in-detecting-the-latest-tags branch December 20, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants