-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test-composite-actions): use autoware:latest-universe-devel
#319
Merged
xmfcx
merged 5 commits into
autowarefoundation:main
from
sasakisasaki:fix-to-use-autoware-latest-universe-devel-ghcr-image
Sep 5, 2024
Merged
fix(test-composite-actions): use autoware:latest-universe-devel
#319
xmfcx
merged 5 commits into
autowarefoundation:main
from
sasakisasaki:fix-to-use-autoware-latest-universe-devel-ghcr-image
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As the previous one is outdated by 6 months * Before this fix, the workflow was failing with following error: ``` Error response from daemon: Head "https://ghcr.io/v2/autowarefoundation/autoware-universe/manifests/humble-latest": unauthorized ``` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
7 tasks
|
@xmfcx Thank you for a quick check, let me investigate, ... . |
I'll add a missing |
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…https://github.com/sasakisasaki/autoware-github-actions into fix-to-use-autoware-latest-universe-devel-ghcr-image
@youtalk -san, we shouldn't need https://hub.docker.com/_/ros/tags I will create an issue for this. Done: |
youtalk
requested changes
Sep 5, 2024
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix not to use outdated image in the workflow.
Related links
Not provided.
Tests performed
By this workflow
Notes for reviewers
Before this fix, the workflow
test-get-self-packages-and-get-modified-packages
was failing with following error.Interface changes
No interface change in this PR
ROS Topic Changes
No ROS topic change in this PR
ROS Parameter Changes
No ROS parameter change in this PR
Effects on system behavior
The failing workflow will be functional.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.