Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use pose_source and twist_source for selecting localization methods #418

Merged
merged 5 commits into from
Jul 21, 2023
Merged

feat: use pose_source and twist_source for selecting localization methods #418

merged 5 commits into from
Jul 21, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 12, 2023 •
edited
Loading

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda
feat: change localization methods section
7f2a2a6 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Jul 12, 2023
@kminoda kminoda added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jul 12, 2023
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited
Loading

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-418/
Modified URLs:

@kminoda kminoda changed the title feat: change localization methods section feat: use pose_source and twist_source for selecting localization methods Jul 12, 2023
@kminoda
fix typo
d3b44ef 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda mentioned this pull request Jul 12, 2023
Merged
7 tasks
@kminoda kminoda marked this pull request as ready for review July 13, 2023 01:53
@kminoda kminoda requested a review from KYabuuchi July 13, 2023 01:54
@kminoda
minor fix
2eade2d 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda @KYabuuchi
Update docs/how-to-guides/integrating-autoware/launch-autoware/locali…
cece86e 
…zation-methods/index.md

Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>
KYabuuchi
KYabuuchi approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 4a0404b into main Jul 21, 2023
@kminoda kminoda deleted the feat/add_pose_twist_estimator_launch_py branch July 21, 2023 04:50
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 22, 2023
Merged
asa-naki pushed a commit to asa-naki/autoware-documentation that referenced this pull request Jul 27, 2023
@kminoda @pre-commit-ci
@KYabuuchi @asa-naki
feat: use pose_source and twist_source for selecting localization…
b9b329a 
… methods (autowarefoundation#418)

* feat: change localization methods section

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix typo

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* Update docs/how-to-guides/integrating-autoware/launch-autoware/localization-methods/index.md

Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>
asa-naki added a commit that referenced this pull request Jul 28, 2023
@asa-naki @pre-commit-ci
@kminoda @KYabuuchi
docs: fix cpell check failed (#421)
1df24ae 
* fix ROS1, ROS2,Github

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

* fix typo

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix image path and image name

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

* fix gtsam ->GTSAM

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix typo

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* add inline ignore words

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

* fix dead link

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* update by precommit

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix ROS2 and organization names

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* feat: use `pose_source` and `twist_source` for selecting localization methods (#418)

* feat: change localization methods section

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix typo

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* Update docs/how-to-guides/integrating-autoware/launch-autoware/localization-methods/index.md

Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

* style(pre-commit): autofix

* fix Azim and Elev

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix product and interface  names and ignore words

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>
alanmengg pushed a commit to alanmengg/autoware-documentation that referenced this pull request Aug 2, 2023
@kminoda @pre-commit-ci
@KYabuuchi @alanmengg
feat: use pose_source and twist_source for selecting localization…
6e17c8f 
… methods (autowarefoundation#418)

* feat: change localization methods section

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix typo

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* Update docs/how-to-guides/integrating-autoware/launch-autoware/localization-methods/index.md

Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
alanmengg pushed a commit to alanmengg/autoware-documentation that referenced this pull request Aug 2, 2023
@asa-naki @pre-commit-ci
@kminoda @KYabuuchi @alanmengg
docs: fix cpell check failed (autowarefoundation#421)
9589620 
* fix ROS1, ROS2,Github

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

* fix typo

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix image path and image name

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

* fix gtsam ->GTSAM

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix typo

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* add inline ignore words

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

* fix dead link

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* update by precommit

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix ROS2 and organization names

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* feat: use `pose_source` and `twist_source` for selecting localization methods (autowarefoundation#418)

* feat: change localization methods section

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* fix typo

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* Update docs/how-to-guides/integrating-autoware/launch-autoware/localization-methods/index.md

Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>

* style(pre-commit): autofix

* fix Azim and Elev

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* fix product and interface  names and ignore words

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: asa-naki <akihisa.nagata@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: Kento Yabuuchi <moc.liamg.8y8@gmail.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KYabuuchi KYabuuchi KYabuuchi approved these changes

Assignees

@YamatoAndo YamatoAndo

@kminoda kminoda

Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kminoda @KYabuuchi @YamatoAndo