Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(planning-design): add planning internal interface #390

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 7, 2023

Description

Add internal interface definition.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe added type:documentation Creating or refining documentation. tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) component:planning Route planning, decision-making, and navigation. labels Jun 7, 2023
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good.
I have small suggestions but feel free to ignore them.

docs/design/autoware-interfaces/components/planning.md Outdated Show resolved Hide resolved
docs/design/autoware-architecture/planning/index.md Outdated Show resolved Hide resolved
TakaHoribe and others added 2 commits June 7, 2023 21:03
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
@TakaHoribe
Copy link
Contributor Author

@maxime-clem Thank you!!!!

@TakaHoribe TakaHoribe changed the title docks(planning-design): add planning internal interface docs(planning-design): add planning internal interface Jun 7, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) June 7, 2023 12:05
@TakaHoribe TakaHoribe merged commit 1c65823 into autowarefoundation:main Jun 7, 2023
@TakaHoribe TakaHoribe deleted the add-planning-internal-interface branch June 7, 2023 12:07
alanmengg pushed a commit to alanmengg/autoware-documentation that referenced this pull request Aug 2, 2023
…ation#390)

* docks(planning-design): add planning internal interface

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update docs/design/autoware-interfaces/components/planning.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

* Update docs/design/autoware-architecture/planning/index.md

Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants