feat(how-to guides): camera intrinsic calibration tool from Autocore #205
Conversation
Signed-off-by: JianKang <egon.kang@autocore.ai>
Signed-off-by: JianKang <egon.kang@autocore.ai>
|
@kenji-miyake could you plz check this pr? many thanks |
| ### Intrinsic Calibration | ||
|
|
||
| - Navigation2 provides a [good tutorial for camera internal calibration](https://navigation.ros.org/tutorials/docs/camera_calibration.html). | ||
| - Autocore provides a [light-weight tool](https://github.com/autocore-ai/calibration_tools/tree/main/camera_intrinsic_calib). |
There was a problem hiding this comment.
@JianKangEgon Is it okay to use Autocore, not AutoCore?
There was a problem hiding this comment.
Autocore is OKay
There was a problem hiding this comment.
@JianKangEgon Which is correct? I believe it's better to be consistent.
There was a problem hiding this comment.
@JianKangEgon @Sharrrrk Could you comment on this? 🙏 I'd like to clarify the rule.
There was a problem hiding this comment.
@kenji-miyake sorry for the late reply, last week was our national holiday. I've double checked, to be consistent, AutoCore would be better, I'll close this pr and propose a new one @Sharrrrk, many thanks
|
@JianKangEgon Sure, could you read the guidelines and check the boxes? |
|
And I've updated the rule of Conventional Commits recently, can I change the type from |
yeah, of course |
kenji-miyake
changed the title
|
replace Autocore with AutoCore |
|
@JianKangEgon Oh, you didn't need to create a new pull request, but it's okay. Thank you. |
Description
Add a new tool for camera intrinsic calibration from Autocore.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.