Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add null checks when accessing camera components #150

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Sep 19, 2024

Description

Sometimes getting stuck with transition scene panel. It happens from time to time. Caused by UI/Graphic Settings Panel's interaction with the cameras on the scene.

This PR fixes the issue.

Related links

Tests performed

Tested in the Editor.

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Alptuğ Cırıt <alptug@leodrive.ai>
@mozhoku mozhoku added the type:bug Software flaws or errors. label Sep 19, 2024
@mozhoku mozhoku self-assigned this Sep 19, 2024
@mozhoku mozhoku marked this pull request as ready for review September 19, 2024 14:11
Signed-off-by: Alptuğ Cırıt <alptug@leodrive.ai>
@mozhoku mozhoku merged commit 171bc78 into autowarefoundation:main Sep 19, 2024
5 of 7 checks passed
@mozhoku mozhoku deleted the fix/ui-trying-to-access-destroyed-object branch September 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants