Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactive mode for rviz npcs #132

Conversation

SujayAmberkar
Copy link
Member

Description

This feature enables spawning interactive NPCs, moving them around by dragging and deleting them.

Related links

Follow point no. 5 to 8 under Advanced Simulations in the following link to test out:
https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/planning-simulation/#placing-dummy-objects

Tests performed

Video shows: Spawning, moving and deleting of an interactive Vehicle.
https://youtu.be/yesetErg4M4

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

SujayAmberkar and others added 6 commits August 12, 2024 23:59
Signed-off-by: SujayAmberkar <sujayamberkar@gmail.com>
Signed-off-by: SujayAmberkar <sujayamberkar@gmail.com>
Signed-off-by: SujayAmberkar <sujayamberkar@gmail.com>
@SujayAmberkar SujayAmberkar self-assigned this Aug 20, 2024
@mozhoku mozhoku changed the title Feat/interactive mode for rviz np cs feat: interactive mode for rviz npcs Aug 20, 2024
Signed-off-by: SujayAmberkar <sujayamberkar@gmail.com>
@mozhoku mozhoku added the type:new-feature New functionalities or additions, feature requests. label Aug 20, 2024
@SujayAmberkar SujayAmberkar marked this pull request as draft August 20, 2024 16:35
Signed-off-by: SujayAmberkar <sujayamberkar@gmail.com>
@SujayAmberkar SujayAmberkar marked this pull request as ready for review August 21, 2024 14:38
Copy link
Collaborator

@mozhoku mozhoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
LGTM 👍

@mozhoku mozhoku merged commit 2049906 into autowarefoundation:main Aug 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants