Qemu: snapshot: Don't forbid snapshot if autodestroy is registered! #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kowshik Jois B S <kowsjois@linux.ibm.com> Description: On v5.8.0 and later versions of lobvirt, it is allowed to take the snapshot of guests created with 'autodestroy' since semantically VIR_DOMAIN_START_AUTODESTROY doesn't really clash with snapshot operations as the VM stays on the same host and thus bound to the same connection. Referrece commit: https://gitlab.com/libvirt/libvirt/-/commit/045a8e197c1e14faa1c32bd637033838269094a2
|
Logs before applying the patch: (2/3) type_specific.io-github-autotest-libvirt.virsh.snapshot_create_as.negative_tests.autodestroy_domain: STARTED Logs after adding the proposed changes: (2/3) type_specific.io-github-autotest-libvirt.virsh.snapshot_create_as.negative_tests.autodestroy_domain: STARTED |
yalzhang
approved these changes
Jan 14, 2025
Yingshun
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kowshik Jois B S kowsjois@linux.ibm.com
Description: On v5.8.0 and later versions of libvirt, it is allowed to take the snapshot of guests created with 'autodestroy' option since semantically VIR_DOMAIN_START_AUTODESTROY doesn't really clash with snapshot operations as the VM stays on the same host and thus bound to the same connection.
Referrece commit: https://gitlab.com/libvirt/libvirt/-/commit/045a8e197c1e14faa1c32bd637033838269094a2