Draft: passt: fix test cases on s390x #5099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
fix_passt_s390x
branch
from
7fc4705 to
d7adeea
Compare
smitterl
force-pushed
the
fix_passt_s390x
branch
from
cfc5f53 to
feb1832
Compare
smitterl
force-pushed
the
fix_passt_s390x
branch
from
1997c78 to
74537a2
Compare
1. s390x doesn't have ACPI 2. s390x virtual interface name inside VM is encX 3. Remove unsupported DAC security driver for unprivileged user if present 4. Pass 'vm_iface' to 'passt.check_vm_ip' to avoid default value with wrong interface naming scheme 5. passt/check_nameserver: remove interface name from ipv6 entry as it might be different between host and guest 6. passt/check_default_gw: let us select which entry to choose because utils_net.get_default_gateway might return more than one, e.g. with multipath routes or when there's more than one interface on the host; same for passt/check_connection 7. passt/check_port_listen: only check for partial process user "'passt" because on x86_64 there's specializatoin 'passt.avx2' but on s390x it's just 'passt' 8. Don't use utils_net.get_host_ip_address because it doesn't let us choose which interface to get the ip address from; use utils_net.get_ip_address_by_interface instead Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
smitterl
force-pushed
the
fix_passt_s390x
branch
from
74537a2 to
d5aefca
Compare
|
This has been split. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if present
with wrong interface naming scheme
it might be different between host and guest
utils_net.get_default_gateway might return more than one, e.g. with
multipath routes or when there's more than one interface on the host;
same for passt/check_connection
because on x86_64 there's specializatoin 'passt.avx2' but on s390x it's
just 'passt'
which interface to get the ip address from; use utils_net.get_ip_address_by_interface
instead