Setup/testing #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add createMessage as a method of mail Refactor sendMail arrow funtion to regular function to have access to the mail object as "this"
sinon tap point-of-view fastify-nodemailer
Closed
use fastify.hasDecorator() to check for "mail"
single quotes -> double quotes to mimic fastify-plugin dependency error message
calls nodemailer.sendMail with correct arguments
| fastify.nodemailer.sendMail = sinon.stub().returnsArg(0) | ||
| const queued = await fastify.mail.sendMail(testContext) | ||
| const { html } = queued | ||
| t.error(sinon.assert.calledOnce(fastify.nodemailer.sendMail), 'nodemailer.sendMail is called') |
There was a problem hiding this comment.
there is a calledOnceWithExactly that we could use here as well.
https://sinonjs.org/releases/latest/assertions/
Not a requested change, but just an fyi
There was a problem hiding this comment.
Good to know, thanks!
jkirkpatrick24
approved these changes
Dec 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan